Skip to content

refactor: revert the disable depth test - #122

Merged
mkumbobeaty merged 1 commit into
alphafrom
refactor/marker-display
Mar 15, 2026
Merged

refactor: revert the disable depth test#122
mkumbobeaty merged 1 commit into
alphafrom
refactor/marker-display

Conversation

@mkumbobeaty

@mkumbobeaty mkumbobeaty commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

Revert the implementation done in this Pr since we want to

  • keep our marker visibility be updated based on viewerProperty.globe.depthTestAgainstTerrain property
  • The changes cause the marker to move it location as globe is moving/rotating

@mkumbobeaty mkumbobeaty changed the title revert the dissable depth test refactor: revert the disable depth test Mar 12, 2026
@mkumbobeaty
mkumbobeaty requested review from bnimit and Copilot and removed request for Copilot March 12, 2026 10:58

@bnimit bnimit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mkumbobeaty
mkumbobeaty merged commit 4617de7 into alpha Mar 15, 2026
8 of 10 checks passed
@mkumbobeaty
mkumbobeaty deleted the refactor/marker-display branch March 15, 2026 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants